On Sun, May 13, 2012 at 8:35 PM, Eugeni Dodonov <[email protected]> wrote:
> On Sun, May 13, 2012 at 5:54 AM, Chris Wilson <[email protected]>wrote: > >> + intel_enable_pch_pll(intel_crtc); >> + >> if (HAS_PCH_LPT(dev)) { >> DRM_DEBUG_KMS("LPT detected: programming iCLKIP\n"); >> lpt_program_iclkip(crtc); >> } else if (HAS_PCH_CPT(dev)) { >> > > Could we just replace this 'else if()' with 'else' to achieve the same > functionality? This way, everything will work and we won't touch wrong > registers on LPT. > Err, English fail here from my side. What I thought was: if (HAS_PCH_LPT(dev)) { DRM_DEBUG_KMS("LPT detected: programming iCLKIP\n"); lpt_program_iclkip(crtc); } else intel_enable_pch_pll(intel_crtc); if (HAS_PCH_CPT(dev)) { u32 sel; temp = I915_READ(PCH_DPLL_SEL); switch (pipe) { default: ... -- Eugeni Dodonov <http://eugeni.dodonov.net/>
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
