On Thu, May 12, 2011 at 06:16:00PM -0700, Keith Packard wrote: > On Thu, 12 May 2011 22:17:22 +0100, Chris Wilson <[email protected]> > wrote: > > > ... as they only had a single PCI-ID each, and so using the pci-id is > > easier than using a capability bit. > > This doesn't seem useful to me; it only saves a couple of bits in the > struct and replaces that with compares. Meh. > > Nacked-by: Keith Packard <[email protected]>
I actually like this: I saves one needless indirection when reading codepaths and trying to find out what code is run for a given pci id. Also, these two bits seem to be the only ones that are used in only _one_ device type, which is a bit confusing. -Daniel -- Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
