Larry Greenfield writes:
>
>This sort of directory hash is very easy to implement in Cyrus; a
>better directory hash than the one included wasn't chosen since we
>wanted something simple that worked well enough for us.
>
>Unfortunately, due to extreme laziness on my part, the directory hash
>function used is used in multiple places.  While any one place can be
>replaced without the others, you probably will want to replace them
>all.
>
>If you'd like to consolidate things into one macro in a header file
>that can be used from each of these, I'd gladly accept the patch and
>we'd be able to change the hash function (at compile time) more
>easily.

Okay, I now have time to look at this.  However, I don't quite
understand the purpose of the macro.  Are you suggesting that part of
the body of each function be replaced by a macro call?  Should the
macro expand to code or to another function call?  Are there examples
of similar coding style elsewhere in Cyrus that you can point me to?



-- 
-Gary Mills-    -Unix Support-    -U of M Academic Computing and Networking-

Reply via email to