[
https://issues.apache.org/jira/browse/HDFS-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109674#comment-18109674
]
ASF GitHub Bot commented on HDFS-17971:
---------------------------------------
slfan1989 commented on PR #8708:
URL: https://github.com/apache/hadoop/pull/8708#issuecomment-5468941377
@zhtttylz Thanks for the review!
> Fix RAT check failure for vendored JSON.java in hadoop-hdfs-rbf
> ---------------------------------------------------------------
>
> Key: HDFS-17971
> URL: https://issues.apache.org/jira/browse/HDFS-17971
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rbf
> Affects Versions: 3.5.1, 3.6.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> The Apache RAT check fails in the hadoop-hdfs-rbf module because
> hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.java
> is reported as an unapproved license file.
>
> This class was copied from Jetty and intentionally retains its original dual
> EPL/Apache license header. The file is already documented in LICENSE.txt and
> excluded from the root-level RAT check.
>
> However, hadoop-hdfs-rbf defines its own RAT exclusion list in its module POM.
> The module-level configuration does not include JSON.java, so the following
> command fails:
>
> ./mvnw -pl hadoop-hdfs-project/hadoop-hdfs-rbf \
> -DskipTests apache-rat:check
>
> The RAT report contains:
> Unapproved: 1, unknown: 1
> The unapproved file is:
> src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.java
>
> We should add this file to the RAT exclusion list in
> hadoop-hdfs-project/hadoop-hdfs-rbf/pom.xml.
>
> This change should not modify the original license header in JSON.java.
> This issue is a follow-up to HADOOP-19951 and apache/hadoop#8654.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
