[
https://issues.apache.org/jira/browse/HDFS-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109614#comment-18109614
]
ASF GitHub Bot commented on HDFS-17971:
---------------------------------------
slfan1989 opened a new pull request, #8708:
URL: https://github.com/apache/hadoop/pull/8708
### Description of PR
The Apache RAT check fails in the `hadoop-hdfs-rbf` module
because
`src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.java`
is reported as an unapproved license file.
This class was copied from Jetty and intentionally retains its original dual
EPL/Apache license header. It is already documented in `LICENSE.txt` and
excluded from the root-level RAT check.
However, `hadoop-hdfs-rbf` defines its own RAT exclusion list, which did not
include this file.
This patch adds `JSON.java` to the module-level RAT exclusion list. It does
not modify the source file or its original license header.
This is a follow-up to HADOOP-19951 and apache/hadoop#8654.
### How was this patch tested?
The failure was reproduced before applying the patch:
```text
Unapproved: 1, unknown: 1
BUILD FAILURE
```
The following command was run after applying the patch:
```
./mvnw -pl hadoop-hdfs-project/hadoop-hdfs-rbf \
-DskipTests apache-rat:check
```
Result:
```
Unapproved: 0, unknown: 0
BUILD SUCCESS
```
### For code changes:
- [ ] Does the title of this PR start with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: Have the integration tests been executed and the
endpoint
declared according to the connector-specific documentation? *Note:
Automated CI
testing doesn't cover all cases so manual testing with cloud storage
is still
required.*
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Fix RAT check failure for vendored JSON.java in hadoop-hdfs-rbf
> ---------------------------------------------------------------
>
> Key: HDFS-17971
> URL: https://issues.apache.org/jira/browse/HDFS-17971
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rbf
> Affects Versions: 3.5.1, 3.6.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
>
> The Apache RAT check fails in the hadoop-hdfs-rbf module because
> hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.java
> is reported as an unapproved license file.
>
> This class was copied from Jetty and intentionally retains its original dual
> EPL/Apache license header. The file is already documented in LICENSE.txt and
> excluded from the root-level RAT check.
>
> However, hadoop-hdfs-rbf defines its own RAT exclusion list in its module POM.
> The module-level configuration does not include JSON.java, so the following
> command fails:
>
> ./mvnw -pl hadoop-hdfs-project/hadoop-hdfs-rbf \
> -DskipTests apache-rat:check
>
> The RAT report contains:
> Unapproved: 1, unknown: 1
> The unapproved file is:
> src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/JSON.java
>
> We should add this file to the RAT exclusion list in
> hadoop-hdfs-project/hadoop-hdfs-rbf/pom.xml.
>
> This change should not modify the original license header in JSON.java.
> This issue is a follow-up to HADOOP-19951 and apache/hadoop#8654.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
