[
https://issues.apache.org/jira/browse/HDFS-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071860#comment-18071860
]
ASF GitHub Bot commented on HDFS-3592:
--------------------------------------
hadoop-yetus commented on PR #8411:
URL: https://github.com/apache/hadoop/pull/8411#issuecomment-4204379634
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | patch | 0m 26s | |
https://github.com/apache/hadoop/pull/8411 does not apply to trunk. Rebase
required? Wrong Branch? See
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
|
| Subsystem | Report/Notes |
|----------:|:-------------|
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8411/1/console |
| versions | git=2.34.1 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> libhdfs should use ClientProtocol::rename2
> ------------------------------------------
>
> Key: HDFS-3592
> URL: https://issues.apache.org/jira/browse/HDFS-3592
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha, 3.0.0-alpha1
> Reporter: Colin McCabe
> Assignee: Colin McCabe
> Priority: Minor
> Labels: BB2015-05-TBR, pull-request-available
> Attachments: HDFS-3592.001.patch
>
>
> It would be nice if libhdfs exposed rename2. This version of rename is much
> more verbose about any errors that occur-- it throws AccessControlException,
> FileAlreadyExists, FileNotFoundException, ParentNotDirectoryException, etc.
> The original rename returns false in many distinct cases, making it ambiguous
> exactly what the problem was.
> For something like fuse_dfs, it is very important to return the correct errno
> code when an error has occurred. rename2 would allow us to do that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]