[
https://issues.apache.org/jira/browse/HDFS-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071859#comment-18071859
]
ASF GitHub Bot commented on HDFS-3592:
--------------------------------------
hadoop-yetus commented on PR #8411:
URL: https://github.com/apache/hadoop/pull/8411#issuecomment-4204371644
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 21m 36s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 54m 20s | | trunk passed |
| +1 :green_heart: | compile | 5m 33s | | trunk passed with JDK Red
Hat, Inc.-21.0.10+7-LTS |
| +1 :green_heart: | compile | 5m 36s | | trunk passed with JDK Red
Hat, Inc.-17.0.18+8-LTS |
| +1 :green_heart: | mvnsite | 1m 45s | | trunk passed |
| +1 :green_heart: | shadedclient | 103m 22s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 22s | | the patch passed |
| +1 :green_heart: | compile | 4m 28s | | the patch passed with JDK
Red Hat, Inc.-21.0.10+7-LTS |
| -1 :x: | cc | 4m 28s |
[/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8411/1/artifact/out/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
| hadoop-hdfs-project_hadoop-hdfs-native-client-jdkRedHat,Inc.-21.0.10+7-LTS
with JDK Red Hat, Inc.-21.0.10+7-LTS generated 2 new + 8 unchanged - 0 fixed =
10 total (was 8) |
| +1 :green_heart: | golang | 4m 28s | | the patch passed |
| +1 :green_heart: | javac | 4m 28s | | the patch passed |
| +1 :green_heart: | compile | 4m 34s | | the patch passed with JDK
Red Hat, Inc.-17.0.18+8-LTS |
| -1 :x: | cc | 4m 34s |
[/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkRedHat,Inc.-17.0.18+8-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8411/1/artifact/out/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkRedHat,Inc.-17.0.18+8-LTS.txt)
| hadoop-hdfs-project_hadoop-hdfs-native-client-jdkRedHat,Inc.-17.0.18+8-LTS
with JDK Red Hat, Inc.-17.0.18+8-LTS generated 2 new + 8 unchanged - 0 fixed =
10 total (was 8) |
| +1 :green_heart: | golang | 4m 34s | | the patch passed |
| +1 :green_heart: | javac | 4m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 0m 35s | | the patch passed |
| +1 :green_heart: | shadedclient | 33m 50s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 11m 1s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8411/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client.txt)
| hadoop-hdfs-native-client in the patch failed. |
| +1 :green_heart: | asflicense | 1m 0s | | The patch does not
generate ASF License warnings. |
| | | 188m 6s | | |
| Reason | Tests |
|-------:|:------|
| Failed CTEST tests | test_test_libhdfs_ops_hdfs_static |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.54 ServerAPI=1.54 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8411/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8411 |
| Optional Tests | dupname asflicense compile cc mvnsite javac unit
codespell detsecrets golang |
| uname | Linux 40cd5d9f27ed 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13
18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f037ec8315112ce24909a3c6607e5c9a2096db58 |
| Default Java | Red Hat, Inc.-17.0.18+8-LTS |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-21.0.10.0.7-1.el8.x86_64:Red Hat,
Inc.-21.0.10+7-LTS /usr/lib/jvm/java-17-openjdk-17.0.18.0.8-1.el8.x86_64:Red
Hat, Inc.-17.0.18+8-LTS |
| CTEST |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8411/1/artifact/out/patch-hadoop-hdfs-project_hadoop-hdfs-native-client-ctest.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8411/1/testReport/ |
| Max. process+thread count | 581 (vs. ulimit of 10000) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U:
hadoop-hdfs-project/hadoop-hdfs-native-client |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8411/1/console |
| versions | git=2.43.7 maven=3.9.11 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> libhdfs should use ClientProtocol::rename2
> ------------------------------------------
>
> Key: HDFS-3592
> URL: https://issues.apache.org/jira/browse/HDFS-3592
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha, 3.0.0-alpha1
> Reporter: Colin McCabe
> Assignee: Colin McCabe
> Priority: Minor
> Labels: BB2015-05-TBR, pull-request-available
> Attachments: HDFS-3592.001.patch
>
>
> It would be nice if libhdfs exposed rename2. This version of rename is much
> more verbose about any errors that occur-- it throws AccessControlException,
> FileAlreadyExists, FileNotFoundException, ParentNotDirectoryException, etc.
> The original rename returns false in many distinct cases, making it ambiguous
> exactly what the problem was.
> For something like fuse_dfs, it is very important to return the correct errno
> code when an error has occurred. rename2 would allow us to do that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
