Hi Alex, At 2025-10-08T00:42:29+0200, Alejandro Colomar wrote: > Actually, I had removed the headers in one of the commits, due to the > bogus comments next to them.
I added (almost?) all of those. > I'd recommend removing all of those comments, which are going to be > false sooner than later. Despite groff's commit rate, the code's pretty stable when it comes to inter-translation unit dependencies. I'm inclined to retain the comments, because it's helpful to me to identify places where we might migrate from "in-house" facilities to ones C99, C++98, or gnulib provide. Much of groff is still written like it's 1989. See Savannah #66672 and #66518. > iwyu(1) is what you should be using to keep the correct includes, but > the comments shouldn't go in the source code. First I've heard of this tool. Thanks for bringing it to my attention. > See the range-diff below. You don't need to submit a v5. I'll hand-merge. Soonish, but I can't promise a 24-hour turnaround or anything like that. Regards, Branden
signature.asc
Description: PGP signature
