Actually, I had removed the headers in one of the commits, due to the
bogus comments next to them. I'd recommend removing all of those
comments, which are going to be false sooner than later. iwyu(1) is
what you should be using to keep the correct includes, but the comments
shouldn't go in the source code.
See the range-diff below.
Cheers,
Alex
Alejandro Colomar (4):
bootstrap.conf: $gnulib_modules: Add stdcountof-h
src/: Use countof() instead of array_length()
[hpftodit]: Use countof() instead of SIZEOF()
src/: Use countof() instead of sizeof division
bootstrap.conf | 1 +
src/devices/grolbp/lbp.cpp | 5 +++--
src/devices/grolj4/lj4.cpp | 5 +++--
src/devices/grops/ps.cpp | 3 ++-
src/devices/grops/psrm.cpp | 11 ++++++-----
src/include/lib.h | 8 --------
src/libs/libgroff/font.cpp | 6 +++---
src/libs/libgroff/glyphuni.cpp | 4 +++-
src/libs/libgroff/make-uniuni | 4 +++-
src/libs/libgroff/uniglyph.cpp | 6 +++---
src/libs/libgroff/uniuni.cpp | 4 +++-
src/preproc/eqn/box.cpp | 14 ++++++++------
src/preproc/eqn/delim.cpp | 4 +++-
src/preproc/eqn/lex.cpp | 11 ++++++-----
src/preproc/eqn/text.cpp | 6 +++---
src/preproc/pic/lex.cpp | 3 ++-
src/preproc/pic/pic.ypp | 7 ++++---
src/preproc/preconv/preconv.cpp | 5 +++--
src/preproc/refer/command.cpp | 5 +++--
src/preproc/refer/ref.cpp | 4 +++-
src/roff/troff/input.cpp | 4 ++--
src/utils/addftinfo/addftinfo.cpp | 5 +++--
src/utils/hpftodit/hpftodit.cpp | 6 +++---
src/utils/hpftodit/hpuni.cpp | 6 +++---
src/utils/tfmtodit/tfmtodit.cpp | 7 ++++---
25 files changed, 80 insertions(+), 64 deletions(-)
Range-diff against v3:
1: 691ec51a5 = 1: 691ec51a5 bootstrap.conf: $gnulib_modules: Add stdcountof-h
2: 7e039cfd3 ! 2: 705cd87b0 src/: Use countof() instead of array_length()
@@ src/libs/libgroff/font.cpp: along with this program. If not, see
<http://www.gn
#include <wchar.h>
-#include "lib.h" // array_length()
--
++#include "lib.h"
+
#include "errarg.h"
#include "error.h"
- #include "cset.h"
@@ src/libs/libgroff/font.cpp: const char *font::load_desc()
bool numeric_directive_found = false;
size_t idx;
@@ src/preproc/preconv/preconv.cpp: along with this program. If not, see
<http://w
#include <getopt.h> // getopt_long()
-#include "lib.h" // array_length()
--
++#include "lib.h"
+
#include "errarg.h"
#include "error.h"
- #include "localcharset.h"
@@ src/preproc/preconv/preconv.cpp: get_BOM(FILE *fp, string &BOM, string
&data)
// UTF-8: 0xEFBBBF
// UTF-16: 0xFEFF or 0xFFFE
3: a9ada18e9 = 3: f6f3d62d4 [hpftodit]: Use countof() instead of SIZEOF()
4: 3a53eea2b = 4: 47f06bf6f src/: Use countof() instead of sizeof division
5: 8b479a5ae < -: --------- src/: Add missing includes
--
2.51.0
