Hello Keith, Keith Marshall <keithmarsh...@users.sourceforge.net> wrote: |I've refactored the appropriate code, in src/roff/troff/input.cpp, with |a view to accommodating this; see patch attached. While I've not yet |progressed any implementation for PDF handling, I have indicated the |point at which it should be invoked. Okay to commit, thus far?
..cool for GNU troff... But what i didn't understand from the beginning is why the code from psrm.cpp isn't factored out to libroff or somewhere, it didn't had the overflow and it uses a nice table-driven approach to check for invalid input characters. Unfortunately the repository doesn't contain information on why input.cpp referred to that (psrm.cpp) but implemented something completely different (but i only used a simply blame and didn't dug deeper). For S-roff i think at times i go with MuPDF to implement PDF. Isn't it a bit fragile to not build a complete object tree? ..but i don't know enough of PDF today. --steffen
