maskit commented on code in PR #12885:
URL: https://github.com/apache/trafficserver/pull/12885#discussion_r2819491818
##########
src/proxy/logging/LogField.cc:
##########
@@ -474,6 +476,9 @@ LogField::marshal_len(LogAccess *lad)
case MSDMS:
return lad->marshal_milestone_diff(m_milestone1, m_milestone2, nullptr);
+ case MSTSMS:
+ return lad->marshal_milestones_csv(nullptr);
Review Comment:
So we can remove these lines here, right? I'm not questioning the necessity
of the new field. Since the new field is not a container, which is accessed
with `{something}`, it should work without these lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
