traeak commented on code in PR #12885:
URL: https://github.com/apache/trafficserver/pull/12885#discussion_r2805503873
##########
src/proxy/logging/LogAccess.cc:
##########
@@ -3494,6 +3495,43 @@ LogAccess::marshal_milestone_diff(TSMilestonesType ms1,
TSMilestonesType ms2, ch
return INK_MIN_ALIGN;
}
+int
+LogAccess::marshal_milestones_csv(char *buf)
+{
+ Dbg(dbg_ctl_log_unmarshal_data, "marshal_milestones_csv");
+
+ swoc::LocalBufferWriter<256> bw;
+
+ bw.print("{}",
m_http_sm->milestones.difference_msec(TS_MILESTONE_TLS_HANDSHAKE_START,
TS_MILESTONE_TLS_HANDSHAKE_END));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_UA_BEGIN));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_UA_FIRST_READ));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_UA_READ_HEADER_DONE));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_CACHE_OPEN_READ_BEGIN));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_CACHE_OPEN_READ_END));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_CACHE_OPEN_WRITE_BEGIN));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_CACHE_OPEN_WRITE_END));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_DNS_LOOKUP_BEGIN));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_DNS_LOOKUP_END));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_SERVER_CONNECT));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_SERVER_CONNECT_END));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_SERVER_FIRST_READ));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_SERVER_READ_HEADER_DONE));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_SERVER_CLOSE));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_UA_BEGIN_WRITE));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_UA_CLOSE));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_SM_FINISH));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_PLUGIN_ACTIVE));
+ bw.print(",{}", m_http_sm->milestones.difference_msec(TS_MILESTONE_SM_START,
TS_MILESTONE_PLUGIN_TOTAL));
+ bw.print("\0");
Review Comment:
This is a false suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]