masaori335 commented on PR #12027:
URL: https://github.com/apache/trafficserver/pull/12027#issuecomment-2689369269
Rocky build is failed. It looks like QPACK also needs to be changed.
```
../src/proxy/http3/QPACK.cc: In member function 'int
QPACK::_encode_header(const MIMEField&, uint16_t, IOBufferBlock*, uint16_t&)':
../src/proxy/http3/QPACK.cc:370:44: error: no matching function for call to
'MIMEField::name_get(int*) const'
370 | const char *name = field.name_get(&name_len);
| ~~~~~~~~~~~~~~^~~~~~~~~~~
In file included from ../include/proxy/hdrs/HTTP.h:30,
from ../src/proxy/http3/QPACK.cc:24:
../include/proxy/hdrs/MIME.h:145:20: note: candidate: 'std::string_view
MIMEField::name_get() const'
145 | std::string_view name_get() const;
| ^~~~~~~~
../include/proxy/hdrs/MIME.h:145:20: note: candidate expects 0 arguments,
1 provided
../src/proxy/http3/QPACK.cc:376:38: error: no matching function for call to
'MIMEField::value_get(int*) const'
376 | const char *value = field.value_get(&value_len);
| ~~~~~~~~~~~~~~~^~~~~~~~~~~~
In file included from ../include/proxy/hdrs/HTTP.h:30,
from ../src/proxy/http3/QPACK.cc:24:
../include/proxy/hdrs/MIME.h:162:20: note: candidate: 'std::string_view
MIMEField::value_get() const'
162 | std::string_view value_get() const;
| ^~~~~~~~~
../include/proxy/hdrs/MIME.h:162:20: note: candidate expects 0 arguments,
1 provided
```
For the `MIMEFieldWrapper`, let's do it on another PR. This PR is already
big enough :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
