hnakamur commented on PR #12027: URL: https://github.com/apache/trafficserver/pull/12027#issuecomment-2681282878
I found some uses of the API and switched them to string_view version in [a1bdbcb](https://github.com/apache/trafficserver/pull/12027/commits/a1bdbcbd00627f29e2b1f6dacc2c37a9006f5664). The two uses are left at https://github.com/apache/trafficserver/blob/a1bdbcbd00627f29e2b1f6dacc2c37a9006f5664/src/proxy/logging/LogUtils.cc#L475-L476 ``` marshalStr(bw, mfp, &MIMEField::name_get); marshalStr(bw, mfp, &MIMEField::value_get); ``` Can I change the signature of `marshalStr` from ``` void marshalStr(swoc::FixedBufferWriter &bw, const MIMEField &mf, const char *(MIMEField::*get_func)(int *length) const) ``` to ``` void marshalStr(swoc::FixedBufferWriter &bw, const MIMEField &mf, std::string_view (MIMEField::*get_func)() const) ``` , or should I change it in another pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
