alamb commented on code in PR #17438:
URL: https://github.com/apache/datafusion/pull/17438#discussion_r2330668605
##########
datafusion/expr/src/expr.rs:
##########
@@ -748,7 +748,9 @@ impl PartialOrd for Alias {
let Some(Ordering::Equal) = cmp else {
return cmp;
};
- self.name.partial_cmp(&other.name)
+ self.name
+ .partial_cmp(&other.name)
+ .filter(|cmp| *cmp != Ordering::Equal || self == other)
Review Comment:
Can we add a link to the follow on ticket? Something like
```suggestion
// TODO: don't recompare
https://github.com/apache/datafusion/issues/17477
.filter(|cmp| *cmp != Ordering::Equal || self == other)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
