alamb commented on code in PR #17438:
URL: https://github.com/apache/datafusion/pull/17438#discussion_r2330666140
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2114,7 +2116,9 @@ pub struct Values {
// Manual implementation needed because of `schema` field. Comparison excludes
this field.
impl PartialOrd for Values {
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
- self.values.partial_cmp(&other.values)
+ self.values
+ .partial_cmp(&other.values)
+ .filter(|cmp| *cmp != Ordering::Equal || self == other)
Review Comment:
Sounds good to me -- I filed a ticket to track:
- https://github.com/apache/datafusion/issues/17477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
