iffyio commented on code in PR #1934:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1934#discussion_r2198077430
##########
src/dialect/snowflake.rs:
##########
@@ -345,6 +345,85 @@ impl Dialect for SnowflakeDialect {
}
}
+ fn is_table_alias(&self, kw: &Keyword, parser: &mut Parser) -> bool {
+ match kw {
+ // The following keywords can be considered an alias as long as
+ // they are not followed by other tokens that may change their
meaning
+ Keyword::LIMIT
+ | Keyword::RETURNING
+ | Keyword::INNER
+ | Keyword::USING
+ | Keyword::PIVOT
+ | Keyword::UNPIVOT
+ | Keyword::EXCEPT
+ | Keyword::MATCH_RECOGNIZE
+ | Keyword::OFFSET
+ if !matches!(parser.peek_token_ref().token, Token::SemiColon |
Token::EOF) =>
+ {
+ false
+ }
+
+ // `FETCH` can be considered an alias as long as it's not followed
by `FIRST`` or `NEXT`
+ // which would give it a different meanings, for example:
+ // `SELECT * FROM tbl FETCH FIRST 10 ROWS` - not an alias
+ // `SELECT * FROM tbl FETCH 10` - not an alias
+ Keyword::FETCH
+ if parser.peek_keyword(Keyword::FIRST)
+ || parser.peek_keyword(Keyword::NEXT)
Review Comment:
```suggestion
if parser.peek_one_of_keyword(&[Keyword::FIRST,
Keyword::NEXT])
```
I think this would be equivalent and simplify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
