colinmarc commented on code in PR #94:
URL: https://github.com/apache/datafusion-iceberg/pull/94#discussion_r4445338552
##########
crates/datafusion/src/read/predicate.rs:
##########
@@ -462,10 +462,21 @@ fn scalar_value_to_datum(value: &ScalarValue) ->
Option<Datum> {
// DataFusion's type coercion always converts them to match the column
type
// (either TimestampMicrosecond or TimestampNanosecond) before
predicate pushdown.
// See unit tests for how those conversions would work if needed.
- ScalarValue::TimestampMicrosecond(Some(v), _) => {
+ //
+ // Note: for types with TZ, the timestamp value itself is always UTC,
+ // even if the timezone is not.
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
