colinmarc commented on code in PR #94: URL: https://github.com/apache/datafusion-iceberg/pull/94#discussion_r4445329057
########## crates/sqllogictest/testdata/slts/df_test/timestamp_predicate_pushdown.slt: ########## @@ -181,3 +181,53 @@ CREATE TABLE default.default.test_timestamp_millis (id INT NOT NULL, ts TIMESTAM # This should fail because Iceberg doesn't support second precision statement error (?s)DataFusion error: IcebergError\(DataInvalid\).*Unsupported Arrow data type: Timestamp\(s\) CREATE TABLE default.default.test_timestamp_seconds (id INT NOT NULL, ts TIMESTAMP(0)) + +statement ok +SET datafusion.execution.time_zone = 'UTC' Review Comment: It's confusing, but without it the `CREATE TABLE` ends up with a normal timestamp column, even with `TIMESTAMP WITH TIME ZONE` specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
