mbutrovich commented on code in PR #26845: URL: https://github.com/apache/datafusion/pull/26845#discussion_r4446910450
########## Cargo.toml: ########## @@ -81,7 +81,7 @@ repository = "https://github.com/apache/datafusion"; # Define Minimum Supported Rust Version (MSRV) rust-version = "1.95.0" # Define DataFusion version -version = "55.1.0" +version = "56.0.0-dev" Review Comment: Should we add a sentence to the [Using the nightly DataFusion builds](https://github.com/apache/datafusion/blob/d0bbb281ca0d3351235614c43695a7c21c087075/docs/source/user-guide/crate-configuration.md?plain=1#L28-L38) section about how to depend on `main` now that it's a pre-release? A git dependency with no version still resolves. A requirement like `version = "56"` next to the git source, or a `[patch.crates-io]` entry used with a `"56"` requirement, no longer matches, because Cargo only matches a pre-release when the requirement names one: ```text error: failed to select a version for the requirement `a = "^56"` candidate versions found which didn't match: 56.0.0-dev help: if you are looking for the prerelease package it needs to be specified explicitly a = { version = "56.0.0-dev" } ``` Downstream projects that test against `main` will hit this the first time they bump, so one line saying to use `version = "57.0.0-dev"` (or leave the version off) would save them the search. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
