sunchao commented on code in PR #7382: URL: https://github.com/apache/datafusion-comet/pull/7382#discussion_r4437102280
########## dev/ensure-jars-have-correct-contents.sh: ########## @@ -107,6 +142,11 @@ allowed_expr+="|^org/apache/spark/CometExecutorPlugin.*$" allowed_expr+="|^org/apache/spark/CometSource.*$" allowed_expr+="|^org/apache/spark/CometTaskMemoryManager.class$" allowed_expr+="|^org/apache/spark/CometTaskMemoryManager.*$" +# Source jars use these filenames for the allowed Spark-private classes above. +allowed_expr+="|^org/apache/spark/Plugins\.scala$" +allowed_expr+="|^org/apache/spark/shuffle/sort/RowPartition\.scala$" +# Shaded dependency sources include their Java module descriptor. +allowed_expr+="|^module-info\.java$" Review Comment: **Keep the source-file exceptions scoped to the sources JAR.** `allowed_expr` is shared by every artifact. I passed the checker a main JAR containing a correctly licensed `libcomet` and a stray root `module-info.java`. Base rejected the unexpected source file, while this revision reported that the artifact looked correct. The same applies to the two Scala source paths above. Could the checker enable those three patterns only for the optional sources JAR and test the same entry in both artifact roles? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
