manuzhang opened a new pull request, #7382: URL: https://github.com/apache/datafusion-comet/pull/7382
## Which issue does this PR close? No separate issue. This addresses two native binary licensing omissions found while verifying 1.2.0-rc1. ## Rationale for this change The 1.2.0-rc1 JARs bundle lz4_flex and Zstandard code through libcomet, but their license and copyright texts are absent from the JAR legal resources. ## What changes are included in this PR? - Add a maintained binary LICENSE containing the existing Apache license and the upstream lz4_flex 0.14.0 MIT and Zstandard 1.5.7 BSD-3-Clause texts and copyrights. Preserve the existing project NOTICE. - Use the existing Maven Shade packaging to put that LICENSE into the main and sources JARs, excluding input copies so incremental builds retain exactly one entry. - Extend the existing artifact checker and Maven invocation to verify the complete LICENSE in both artifacts, with a specific RAT exclusion and short maintenance instructions. This fixes the two confirmed omissions. It does not claim a complete audit of every bundled native dependency. ## How are these changes tested? - Eight focused artifact checks cover valid main/sources JARs, non-native JARs, missing/truncated/duplicate LICENSE entries and missing copyrights. The original RC1 artifact is rejected for the known omission. - Spark 3.4/Scala 2.12 and Spark 4.1/Scala 2.13 root release-profile `clean verify -DskipTests` passed with real macOS native payloads, as did incremental Spark 4.1 packaging. All four main/sources JARs have exactly one matching LICENSE and the unchanged project NOTICE. Committed-source Apache RAT and formatting passed. - [Exact-head Linux CI](https://github.com/manuzhang/datafusion-comet/actions/runs/41271716914) passed at `82b1ed3ba615997d4f2a77b301104ded557c794f` on attempt 1: 23 successful jobs, 18 skipped and no failures. Native build, Clippy, Rust tests (2,732 default; 15 Python-UDF; five jemalloc), all four Spark 4.1 shards (5,531 passed; 31 canceled; 18 ignored), TPC-H/TPC-DS result verification, and real Linux main/sources JAR license checks passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
