mkleen commented on code in PR #26988:
URL: https://github.com/apache/datafusion/pull/26988#discussion_r4436923434
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -935,6 +937,10 @@ fn encoded_value_type(data_type: &DataType) -> &DataType {
/// [`HllGroupsAccumulator`]. The fixed-domain types (booleans / small ints)
and
/// `Null` fall back to the per-group [`Accumulator`] path.
fn is_hll_groups_type(data_type: &DataType) -> bool {
+ if has_float_leaf(data_type) {
Review Comment:
This should move up to `is_supported_type`, this is not only group related.
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -989,6 +995,34 @@ mod tests {
use super::*;
use std::hash::BuildHasher;
+ #[test]
+ fn nested_float_unsupported() {
Review Comment:
I think the slt tests are sufficient. we don't need this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
