pujitha24 opened a new pull request, #26988: URL: https://github.com/apache/datafusion/pull/26988
## Which issue does this PR close? - Closes #26985. ## Rationale for this change `approx_distinct` rejects floats (bare, or inside dictionary/REE) with a "not implemented" error, but silently accepted lists, structs and maps containing floats. ## What changes are included in this PR? A recursive `contains_float` check in `is_hll_groups_type`, and the nested-type accumulator arm now uses the `is_supported_type` guard, so nested floats get the same not-implemented error. ## What is the testing strategy for this PR? New unit test `nested_float_unsupported` and new sqllogictest cases in `aggregate.slt` (List/Struct/Map, with and without GROUP BY). Unit tests and the new slt cases pass; other pre-existing failures in the aggregate slt run also occur on the base. Full extended suite not run. ## Are there any user-facing changes? Queries over nested-float columns that previously returned a count now return the not-implemented error, consistent with bare floats. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
