haochunchang commented on code in PR #26202:
URL: https://github.com/apache/datafusion/pull/26202#discussion_r4431462013
##########
datafusion/sql/tests/cases/diagnostic.rs:
##########
@@ -791,3 +840,291 @@ fn test_window_function_alias_in_having() -> Result<()> {
assert_eq!(diag.span, Some(spans["a"]));
Ok(())
}
+
+#[test]
+fn test_duplicate_cte_name() -> Result<()> {
Review Comment:
I agree with human needs to understand the code as well.
There are several different error cases for just duplicate tables could
happen.
Maybe I can try to split into smaller PR, each focuses on a specific error
case.
Or takes what we learned from these review to re-think if there is another
simpler way to do it.
Thanks again for the feedback and your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
