LucaCappelletti94 commented on code in PR #2556:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2556#discussion_r4367193102
##########
src/parser/mod.rs:
##########
@@ -9690,7 +9690,9 @@ impl<'a> Parser<'a> {
| Keyword::GENERATED
| Keyword::AS
),
- _ => true, // e.g. comma immediately after column name
+ // A single-quoted string is a valid type name in SQLite's ids
grammar.
+ Token::SingleQuotedString(_) => false,
Review Comment:
Leading `NULL` is parsed as a constraint on an untyped column in
[947dab70](https://github.com/apache/datafusion-sqlparser-rs/commit/947dab70fefd66712a22365bfc394908543caf59),
and I added adequate tests for the rejected variants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
