jayzhan211 commented on PR #26461: URL: https://github.com/apache/datafusion/pull/26461#issuecomment-6268896852
@2010YOUY01 Thanks. To see who would need that API, I looked at how downstream projects use the rule today: - greptimedb moves the rule to the end of its list. sail and cube add it to their own rule lists. The planner check now covers all three, and the deprecation warning tells them they can drop the rule. - spiceai looks up the rule's position in the default list and panics if the rule is missing. The upgrade guide covers that case. - openobserve places the rule before its own rules (`JoinReorderRule`, `RemoteScanRule` and others), with a comment saying those rules are not checked. streamling replaces the default rules and leaves out both `EnforceDistribution` and `SanityCheckPlan`. After this PR, both projects' plans are checked. The last group is the one your comment is about. If the check rejects a correct plan, for example one whose ordering holds but cannot be proven from the plan's properties, those projects can no longer skip the check. I'd suggest adding a way to skip or replace the check in a follow-up, once someone needs it, rather than guessing at the shape of the API now. I'm happy to add it here instead if you'd prefer it to ship in the same release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
