jayzhan211 commented on PR #26461: URL: https://github.com/apache/datafusion/pull/26461#issuecomment-6268896458
@alamb Thanks for running these. The second run is the quieter one. In it, `physical_plan_tpch_all` is 1.02, `physical_plan_tpcds_all` is 1.01 and `physical_plan_clickbench_all` is 1.00. In the first run, per-query numbers move by up to 10% in both directions, which is more than the gap between the branches. The change should not add planning work. Before, the planner walked the final plan twice: once in `SanityCheckPlan` and once in its own `InvariantChecker(Executable)` pass. Now it walks the plan once and runs the same checks. The only new cost when planning succeeds is one `Arc` clone per rule, about 20 in the default list. The extra search that finds which rule to name runs only when the check fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
