viirya commented on code in PR #7090: URL: https://github.com/apache/datafusion-comet/pull/7090#discussion_r4307796865
########## docs/source/_templates/redirect.html: ########## @@ -0,0 +1,20 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<html><head><noscript><meta http-equiv="refresh" content="0; url=${to_uri}" /></noscript><script>var target = "${to_uri}";if (window.location.hash) {window.location.replace(target.split("#")[0] + window.location.hash);} else {window.location.replace(target);}</script></head></html> Review Comment: Non-blocking: with the old hash replacing the target's, a deep link only lands on its section when the old anchor still exists on the new page. For the three Parquet redirects, most old anchors don't: - `compatibility/scans.html`: `#schema-mismatch-handling` survives; `#parquet-scan-limitations` doesn't. - `tuning/scans.html`: `#filter-pushdown--late-materialization` survives; `#parquet-reader-tuning`, `#parquet-native-scans` and `#iceberg-scan-tuning` don't. - `parquet-iceberg-known-issues.html`: only `#differences-that-are-not-comet-bugs` survives; `#parquet-reads`, `#iceberg-writes`, `#results-that-differ-from-spark` and the rest don't. For those, the browser ignores the unknown fragment and the reader lands at the top of `parquet.html`, not at `#reading`, `#tuning` or `#known-issues`. Letting the target's anchor win when it has one, and carrying the old hash over only when it doesn't, would send every Parquet deep link to its section. `iceberg-writes.html` would still carry its anchors through, since its target has none and they all still exist: ```js var target = "${to_uri}"; if (window.location.hash && target.indexOf("#") < 0) { target += window.location.hash; } window.location.replace(target); ``` The cost is that the two surviving Parquet anchors land on their parent section instead. The known-issues page was only up for a day, so this mostly matters for the older `scans.html` links. Fine either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
