andygrove commented on PR #7090: URL: https://github.com/apache/datafusion-comet/pull/7090#issuecomment-6248012122
Thanks @viirya! All addressed in 91e21cba1, and the branch is merged with `main`. - `expressions.md` is back to the one-line link change. - The field-id entry moved to a new "Differences that are not Comet bugs" section under Parquet's Known Issues. - sphinx-reredirects takes fragments, so the redirects now target `#reading`, `#tuning` and `#known-issues`. Its default template appends the old URL's hash to the target, which would give `parquet.html#tuning#filter-pushdown...`, so I added a small redirect template that uses the old hash in place of the target's. Deep links still resolve. - Both Known Issues sections now point to the S3 and Azure limitations, renamed to `S3 Limitations` and `Azure Limitations`. Parquet's Known Issues also links to Iceberg's. - The Writing section now says testing only and lists the scope limits (non-partitioned, non-bucketed, no `maxRecordsPerFile` on Spark 4.0+). - The duplicated invalid UTF-8 and duplicate-field entries are now a link to the scan-time error section, and the "See the Iceberg page" wording is fixed. I ran a source-only Sphinx build on `main` and on this branch: 82 warnings on each, none new. The description now has a table of where each old page went, and #7101 tracks the Scala comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
