LucaCappelletti94 opened a new pull request, #2661: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2661
SQLite ends a `/* ... */` comment at the next `*/` or at the end of input, whichever comes first (https://www.sqlite.org/lang_comment.html), so `SELECT 1 /* x` runs and returns `1`. The tokenizer rejected it in every dialect with `Unexpected EOF while in a multi-line comment`. A new dialect method, `supports_unterminated_block_comments`, enabled for SQLite, makes the tokenizer return the open comment as whitespace when the input ends inside it. Other dialects keep the error, which matches DuckDB and PostgreSQL rejecting an unterminated `/*` comment. Tests cover SQLite, including input that is only an open comment, and the exact error in every other dialect. Principal doubt I have here is that ONLY SQLite to my knowledge has this quirk, so I wonder whether approaching this as a `Dialect` method is the wrong manner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
