alamb commented on PR #25527: URL: https://github.com/apache/datafusion/pull/25527#issuecomment-6200740769
> so ~460 lines of real code, not 1150. Since we have to maintain both code and tests so I think evaluating the entire size of the diff is the right metric, includig tests > That position isn't derivable from __grouping_id's (ordinal << group_count) | mask by formula; Why not? If the aggregates order the sets differently, wouldn't there be a projection to reorder the output columns correctly? Or perhaps we could introduce a Projection to do so -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
