Omega359 commented on code in PR #25839: URL: https://github.com/apache/datafusion/pull/25839#discussion_r4274909852
########## benchmarks/sql_benchmarks/pwmj/pwmj.benchmark.template: ########## @@ -0,0 +1,48 @@ +# Shared template for the `pwmj` suite: `PiecewiseMergeJoin`'s classic joins +# (INNER / LEFT / RIGHT / FULL) over a single range predicate, +# `lhs.key < rhs.key`. +# +# Parameters set by each qNN.benchmark: +# QPAD zero-padded query id +# JOIN SQL join keyword (INNER, LEFT, RIGHT, FULL) Review Comment: I think I missed that detail. I had thought those were optional user provided parameters - if not, ignore my comment :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
