SubhamSinghal commented on code in PR #25839: URL: https://github.com/apache/datafusion/pull/25839#discussion_r4273414579
########## benchmarks/sql_benchmarks/pwmj/pwmj.benchmark.template: ########## @@ -0,0 +1,48 @@ +# Shared template for the `pwmj` suite: `PiecewiseMergeJoin`'s classic joins +# (INNER / LEFT / RIGHT / FULL) over a single range predicate, +# `lhs.key < rhs.key`. +# +# Parameters set by each qNN.benchmark: +# QPAD zero-padded query id +# JOIN SQL join keyword (INNER, LEFT, RIGHT, FULL) Review Comment: @Omega359 — want to make sure I build the right thing. These five are per-query constants (each `qNN.benchmark` sets them after its `template` line, and template parameters are looked up before env vars, so as `[[options]]` they'd show in `--help` but be overridden by every query. If the goal is to run one join type across all regimes (e.g. only LEFT), that's a real gap today. Let me know if you want this, I can work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
