ozenyunus35 opened a new pull request, #26312:
URL: https://github.com/apache/datafusion/pull/26312

   ## Which issue does this PR close?
   
   - Closes #26308.
   
   ## Rationale for this change
   
   The `Wildcard` and `QualifiedWildcard` arms of `project_with_validation` 
repeated the same REPLACE handling and the same normalize/columnize step, and 
the `Expression` arm repeated that step a third time.
   
   ## What changes are included in this PR?
   
   - A `push_validated` closure in the loop does the normalize/columnize (or 
pass-through) push, and all three arms use it.
   - A small `apply_replace` helper applies a wildcard's REPLACE clause if 
there is one.
   
   Each wildcard arm now only computes its expansion. No behaviour change.
   
   ## What is the testing strategy for this PR?
   
   Covered by existing tests: the builder unit tests in `datafusion-expr` and 
the wildcard / `REPLACE` cases in `select.slt`, `unnest.slt`, `functions.slt` 
and `aggregate.slt`, which all pass locally.
   
   ## Are there any user-facing changes?
   
   No.
   
   I used an AI assistant to help draft parts of the code; I reviewed the 
changes and ran the tests myself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to