andygrove commented on PR #6835: URL: https://github.com/apache/datafusion-comet/pull/6835#issuecomment-6132087043
@kazuyukitanimura, @sunchao, all of this is in 79b4d336d0, and the docs note is in ce6a82fe93: the compatibility guide has a Hash Join Output Order section next to Sort Aggregation now, with the fallback for a first sort key Comet cannot express. The shapes that stay conservative are in #6922. On the backport, I don't plan one. On branch-1.1 the bug only shows with `spark.comet.exec.inMemoryCache.enabled` or `spark.comet.sparkToColumnar.enabled` turned on, and this change doesn't apply cleanly there, so it would be a manual port for an opt-in path. @dwsmith1983, thanks for the go-ahead on the order. A `run-spark-4.1-tests` run comes next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
