andygrove commented on PR #6835: URL: https://github.com/apache/datafusion-comet/pull/6835#issuecomment-6127656651
@dwsmith1983, sunchao's review monitor found a hole in what I said above about 2f95eefb36. The walk sees the NOT IN only when it's in the same native plan as the outer join. Once the NOT IN's output is cached, the outer join reads it as a JVM input, declares the order anyway, and splits groups again. 2e0fb63469 closes that on the JVM side, see the thread on `planner.rs`. With it, this PR doesn't depend on #6810 for correctness, so my question about the landing order still stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
