dwsmith1983 commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4246896564
##########
dev/ci/compute-changes.py:
##########
@@ -577,6 +604,12 @@
"iceberg_1_9": ["nightly", "label:run-iceberg-tests"],
"iceberg_1_10": ["nightly", "label:run-iceberg-tests"],
"iceberg_1_11": ["queue", "label:run-iceberg-tests"],
+ # Same shape for the Delta contrib suites: Spark 3.5 is the profile the
+ # MinIO and feature-off jobs already pin, so it is the one the queue runs;
+ # 4.0 and 4.1 run nightly. One label opts a pull request into all three.
+ "delta_3_5": ["queue", "label:run-delta-tests"],
Review Comment:
> Could `delta_3_5` move to the nightly tier with 4.0 and 4.1, still behind
`run-delta-tests`? And could the Spark 3.5 strict warnings compile in
`pr_build_linux.yml` add the `delta` profile, so a change that breaks the
contrib build fails on its own PR?
Both in 3062796c6. `delta_3_5` is nightly now, still behind
`run-delta-tests`, and the strict warnings job runs `-Pspark-3.5,delta
-Pstrict-warnings`. Since nothing in the queue runs the contrib any more,
`contrib/delta-spark/**` also routes to the Linux PR build, so a change under
the contrib alone gets that compile too. The cost is that a contrib-only PR
runs the whole Linux pipeline; a narrower output that gates only the strict job
would avoid that if you'd rather. The workflows README, `ci.md` and
`check-ci-config.py` follow the new tiering, and `ci.md` lists
`run-delta-tests` among the labels to reach for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
