zhangfengcdt commented on PR #6682: URL: https://github.com/apache/datafusion-comet/pull/6682#issuecomment-6117544504
> @zhangfengcdt you handled float edge cases in #6556 and #6599, so you may have useful context for the FLOAT and DOUBLE map key rules here. If you have time, would you be able to review it? Thanks. Thanks for this, the four-way rule matches what I see in `ArrayBasedMapBuilder` on branch-4.1, and keeping struct and array keys declined fits the tree map with SQL ordering that Spark uses for them. I found no other issues, just one same suggestions as @viirya inline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
