andygrove commented on PR #48: URL: https://github.com/apache/datafusion-iceberg/pull/48#issuecomment-6110865826
> LGTM, thanks @NoahKusaba! > > @gabotechs, I agree on moving to `insta` for consistency with DataFusion. It probably fits best in a follow-up that converts the existing `expect!` snapshots, rather than in this PR. > > Also, the files that #18 added are missing the ASF license header, which the RAT check in #32 will flag. Could you add it to these? > > * `crates/datafusion/src/test_utils/mod.rs` > * `crates/datafusion/src/test_utils/harness.rs` > * `crates/datafusion/tests/external_table.rs` > * `crates/datafusion/tests/filter_pushdown.rs` > * `crates/datafusion/tests/limit_pushdown.rs` > * `crates/datafusion/tests/projection_pushdown.rs` > * `crates/datafusion/testdata/iceberg/taxi/README.md` I also created a separate PR split out of #32 to add the RAT checks. https://github.com/apache/datafusion-iceberg/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
