NoahKusaba commented on PR #48: URL: https://github.com/apache/datafusion-iceberg/pull/48#issuecomment-6105224821
Thanks for the review @andygrove, I was going to wait for https://github.com/apache/datafusion-iceberg/pull/18 to also merge (along with the other refactors), but to be fair it isn't a real blocker so I've addressed all of the comments in the new commit. Small note on the doc example I provided that is now removed, I was asked to provide one for public api's in previous PR's, but I agree it's unnecessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
