kosiew commented on PR #26122:
URL: https://github.com/apache/datafusion/pull/26122#issuecomment-6096777256
Thanks @toastal, fair points. This PR is already merged, so I'll follow up.
You're right about the security issue: direnv allow approves only the
top-level .envrc. That means .envrc.local (and parent .envrc files loaded
through source_up_if_exists) run without being re-approved.
I agree with option 3: untrack .envrc and add it to .gitignore. That also
fixes #26101, which only happened because .envrc became tracked. It removes the
need for .envrc.local and the flake/nix assumption too. The docs can just say
echo 'use flake' > .envrc && direnv allow. A shell.nix for stable Nix users
also sounds good.
@VVKot, what are your thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
