toastal commented on PR #26122: URL: https://github.com/apache/datafusion/pull/26122#issuecomment-6093405280
There are 2 issues with this: 1. flakes are experimental & should a project should never assume that if nix is on PATH that flakes are used. This will fail for a number of users. 2. Was removing the file all together considered an option since those know how to use direnv can just run `echo "use nix" >>.envrc && direnv allow`? Is this file providing enough value to warrant the [potential security issue](https://github.com/direnv/direnv/issues/348#issuecomment-571168850)? The alternative is putting the whole `.envrc` in the `.gitignore` which allows any user to customize this as they see fit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
