xavlee commented on code in PR #24697:
URL: https://github.com/apache/datafusion/pull/24697#discussion_r4180678200
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -890,6 +891,12 @@ pub struct AggregateExec {
/// input order". When that is not possible, the constructor overwrites it
/// with the unordered variant [`InputOrderMode::Linear`].
input_order_mode: InputOrderMode,
+ /// Describes when the executor can determine that groups are complete.
+ ///
+ /// Input ordering describes a subset of the cases in which groups can be
+ /// safely emitted before the input ends. Full group completion requires
only
+ /// that rows for each complete grouping tuple are contiguous.
+ group_completion_mode: GroupCompletionMode,
Review Comment:
I combined these two modes into `GroupCompletionMode` since that's the more
general property the runtime needs to determine how to emit groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
