xavlee commented on PR #24697: URL: https://github.com/apache/datafusion/pull/24697#issuecomment-5987744135
Hi @2010YOUY01, thanks for the review 🙂. If no other optimization currently depends on the existing sorting guarantee, then the practical alternative you mentioned seems tenable -- we can extend the model should a use case for ordering arises. I've updated this PR in the three ways you mentioned: - renamed `ordering` to `completion_mode` - replaced folded order/completion mode into the single `GroupCompletionMode` instead of maintaining both - Renamed `ordered_*_stream` to `clustered_*_stream` One naming question: would you prefer to rename `GroupCompletionMode` to `GroupClusteringMode` to align with the clustering terminology you suggested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
