mohitgurav20 commented on PR #25716: URL: https://github.com/apache/datafusion/pull/25716#issuecomment-5968238934
@kosiew Good catch on the slicing edge case—using just the pointer address definitely wasn't safe enough there. I've just pushed a fix for this. The deduplication map now uses a (pointer_address, length) tuple as the key to properly identify exact buffer ranges. I also added the test coverage you requested: A new test specifically for BinaryViewArray deduplication. A regression test that verifies the slicing behavior to ensure the retained buffer correctly covers the remapped views without collisions. Everything is passing on my end. Let me know how it looks to you now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
