github-actions[bot] commented on PR #25688: URL: https://github.com/apache/datafusion/pull/25688#issuecomment-5934247561
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.1.0 (current) Built [ 65.443s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.036s] (current) Building datafusion v55.1.0 (baseline) Built [ 65.071s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.624s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 133.186s] datafusion Building datafusion-ffi v55.1.0 (current) Built [ 60.305s] (current) Parsing datafusion-ffi v55.1.0 (current) Parsed [ 0.066s] (current) Building datafusion-ffi v55.1.0 (baseline) Built [ 60.045s] (baseline) Parsing datafusion-ffi v55.1.0 (baseline) Parsed [ 0.065s] (baseline) Checking datafusion-ffi v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.276s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 122.307s] datafusion-ffi Building datafusion-physical-optimizer v55.1.0 (current) Built [ 45.766s] (current) Parsing datafusion-physical-optimizer v55.1.0 (current) Parsed [ 0.024s] (current) Building datafusion-physical-optimizer v55.1.0 (baseline) Built [ 45.217s] (baseline) Parsing datafusion-physical-optimizer v55.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-physical-optimizer v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.116s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field --- Description: A struct has a new non-public field that causes downstream code to be unable to construct it with a struct expression, including functional-update syntax. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_private_field.ron Failed in: field JoinSelection.phase in /home/runner/work/datafusion/datafusion/datafusion/physical-optimizer/src/join_selection.rs:87 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 92.335s] datafusion-physical-optimizer Building datafusion-physical-plan v55.1.0 (current) Built [ 42.078s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.178s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 42.694s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.178s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.675s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 86.980s] datafusion-physical-plan Building datafusion-proto v55.1.0 (current) Built [ 61.328s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.018s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 60.123s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.118s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 122.943s] datafusion-proto Building datafusion-session v55.1.0 (current) Built [ 42.567s] (current) Parsing datafusion-session v55.1.0 (current) Parsed [ 0.011s] (current) Building datafusion-session v55.1.0 (baseline) Built [ 43.892s] (baseline) Parsing datafusion-session v55.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-session v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.190s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 87.790s] datafusion-session Building datafusion-sqllogictest v55.1.0 (current) Built [ 110.044s] (current) Parsing datafusion-sqllogictest v55.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-sqllogictest v55.1.0 (baseline) Built [ 109.131s] (baseline) Parsing datafusion-sqllogictest v55.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.096s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 222.038s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
