coderfender commented on code in PR #4587:
URL: https://github.com/apache/datafusion-comet/pull/4587#discussion_r4156541132
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -2488,6 +2488,17 @@ trait CometHashJoin {
case FullOuter => JoinType.FullOuter
case LeftSemi => JoinType.LeftSemi
case LeftAnti => JoinType.LeftAnti
+ // Native only for equi-join keys that are bare column refs /
literals: Spark short-
+ // circuits on first match and can skip key evaluation, but DF
evaluates all keys eagerly
+ // over the batch, so a computed key (e.g. a throwing cast) could
error on skipped rows.
+ case ExistenceJoin(_)
+ if CometConf.COMET_EXEC_EXISTENCE_JOIN_ENABLED.get(join.conf) &&
+ join.condition.isEmpty &&
+ (join.leftKeys ++ join.rightKeys).forall {
+ case _: Attribute | _: Literal => true
Review Comment:
fixed build / import error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
