viirya commented on PR #25815: URL: https://github.com/apache/datafusion/pull/25815#issuecomment-5882572200
The benchmark run failed. The runner doesn't seem to know `date_bin`: the log ends with its list of supported benchmarks, and `date_bin` is a criterion benchmark in `datafusion-functions` rather than one of those suites. Locally, `cargo bench -p datafusion-functions --bench datetime_expressions -- date_bin` goes from 2.78 µs on `main` to 2.50 µs on this branch. That benchmark covers in-range `Timestamp(Second)` values, which take the i64 fast path; the i128 path only runs for values whose i64 nanosecond computation overflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
