alamb commented on issue #2588: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2588#issuecomment-5857261941
> At this time, we do not have a structured PR template, and I have been applying/deleting manually the "waiting on contributor/reviewer" labels, and I am already falling behind. I think they are useful as a mechanism to easily see which PRs need reviewing and which do not. Yes I agree. I just want to point out (perhaps it will help with your own mental sanity) that it is basically impossible to keep up with PRs (and if you get better at it, I predict you will just encourage more PRs). So that is not to say don't try, just don't get discouraged if you are always behind, because that is the fundamental nature of these open source projects, I think > I suggest to add the following mechanisms: > > * [ ] (PR Template) Template lines: `Reference:`, `Issues:`, `Fuzzed:`, a kind checklist, reminders to search for duplicate PRs and issues, and an "I solemnly swear this is not slop" checkbox, with agent-written code being fine if adequately reviewed by its author. Anything maintainers deem slop gets closed.[ ] PR Labels: kind (the names [`generate-changelog.py`](https://github.com/apache/datafusion-sqlparser-rs/blob/main/dev/release/generate-changelog.py) reads, plus `ci`, `fuzz harness`, `fuzz corpus`), `resolves issue`/`partial issue`, and `unfuzzed` (a bug fix or new syntax without a new `fuzz/fuzz_seeds/` entry).* [ ] CI Bot-owned state: Sounds good -- you can perhaps crib from the datafusion and arrow ones if there is anything that might be useful. They have served us well for many years and try to encourage people to submit good PRs - https://github.com/apache/datafusion/blob/main/.github/pull_request_template.md?plain=1 - https://github.com/apache/arrow-rs/blob/main/.github/pull_request_template.md?plain=1 > > * `waiting on reviewer` when ready for review.* `waiting on contributor` plus conversion to draft on `CHANGES_REQUESTED`.* `ready to merge` on approval of the head commit.* `needs rebasing` on conflict.[ ] `stale.yml` ignores time spent waiting on reviewers, so we do not close PRs whose only fault is us being slow with reviews. Yeah if you can figure that out that would be great. We haven't been able to automate this in the main datafusion repo, but it might be eaiser here as there are fewer maintainer workflows to merge together -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
